Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MoM test #578

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Remove MoM test #578

merged 3 commits into from
Nov 14, 2023

Conversation

lbonaldo
Copy link
Collaborator

This removes the test for the MoM. The test will be reinstated for an updated version of the module.

@lbonaldo lbonaldo requested a review from cfe316 November 13, 2023 22:54
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2091f85) 40.83% compared to head (b20f6a9) 38.34%.

❗ Current head b20f6a9 differs from pull request most recent head 07fdc74. Consider uploading reports for the commit 07fdc74 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #578      +/-   ##
===========================================
- Coverage    40.83%   38.34%   -2.49%     
===========================================
  Files          126      126              
  Lines         6482     6480       -2     
===========================================
- Hits          2647     2485     -162     
- Misses        3835     3995     +160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cfe316 cfe316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this. Unfortunately due to the random nature of MoM we need to find a better way to test this in the future.

@lbonaldo lbonaldo merged commit 6f7ec0d into GenXProject:develop Nov 14, 2023
2 checks passed
@lbonaldo lbonaldo deleted the fix-MoM_test branch June 25, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants